Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/use context with timeout #93

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

greut
Copy link

@greut greut commented Sep 15, 2020

Another attempt on top of @vthiery 's work (cf #91)

vthiery and others added 3 commits August 19, 2020 00:12
When a request is being cancelled by the caller via the context, even though the underlying HTTP client should not perform any more request and directly return, the backoff mechanism still kicks in and leaves the caller waiting for multiple backoff periods for nothing.
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 89.698% when pulling bd0d2c8 on greut:feat/use-context-with-timeout into 2f1fd27 on gojek:master.

@coveralls
Copy link

coveralls commented Sep 15, 2020

Coverage Status

Coverage decreased (-8.6%) to 91.406% when pulling bbfba3c on greut:feat/use-context-with-timeout into 2f1fd27 on gojek:master.

Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants